Skip to content

Forgot an end div omg#305

Merged
validbeck merged 2 commits intomainfrom
beck/log-metrics-fix
Jan 30, 2025
Merged

Forgot an end div omg#305
validbeck merged 2 commits intomainfrom
beck/log-metrics-fix

Conversation

@validbeck
Copy link
Collaborator

Internal Notes for Reviewers

Forgot an end div in the "Log metrics over time" notebook causing display issues when rendered in docs 🤦🏻

@validbeck validbeck added the internal Not to be externalized in the release notes label Jan 30, 2025
@validbeck validbeck self-assigned this Jan 30, 2025
Copy link
Collaborator

@nrichers nrichers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🤖

@validbeck validbeck merged commit 613e9f4 into main Jan 30, 2025
3 checks passed
@validbeck validbeck deleted the beck/log-metrics-fix branch January 30, 2025 18:52
@github-actions
Copy link
Contributor

PR Summary

This pull request addresses a minor bug in the log_metrics_over_time.ipynb notebook. The change involves correcting the HTML block closure for an informational alert. Previously, the HTML block was not properly closed, which could potentially lead to rendering issues in some environments. The fix ensures that the HTML block is correctly terminated with a </div> tag, improving the document's structural integrity and display consistency.

Test Suggestions

  • Open the log_metrics_over_time.ipynb notebook in a Jupyter environment and verify that the informational alert is displayed correctly without any rendering issues.
  • Check the HTML source of the rendered notebook to ensure that the <div> block is properly closed.
  • Test the notebook in different browsers to confirm consistent rendering of the alert block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants